diff --git a/internal/nature_test.go b/internal/nature_test.go index 26c764c..eb7baec 100644 --- a/internal/nature_test.go +++ b/internal/nature_test.go @@ -17,12 +17,12 @@ func TestNature_String(t *testing.T) { want: "unknown", }, { - name: "return unknown", + name: "return G01", nature: internal.NatureG01, want: "G01", }, { - name: "return unknown", + name: "return G20", nature: internal.NatureG20, want: "G20", }, diff --git a/internal/open_figi_test.go b/internal/open_figi_test.go index 313a6d4..8325f2c 100644 --- a/internal/open_figi_test.go +++ b/internal/open_figi_test.go @@ -33,7 +33,7 @@ func TestOpenFIGI_SecurityTypeByISIN(t *testing.T) { want: "Common Stock", }, { - name: "bas status code", + name: "bad status code", client: NewTestClient(t, func(req *http.Request) (*http.Response, error) { return &http.Response{ Status: http.StatusText(http.StatusTooManyRequests), diff --git a/internal/trading212/record.go b/internal/trading212/record.go index f5debd2..61f2ff8 100644 --- a/internal/trading212/record.go +++ b/internal/trading212/record.go @@ -121,17 +121,17 @@ func (rr RecordReader) ReadRecord(ctx context.Context) (internal.Record, error) return Record{}, fmt.Errorf("parse record timestamp: %w", err) } - conversionFee, err := parseOptinalDecimal(raw[16]) + conversionFee, err := parseOptionalDecimal(raw[16]) if err != nil { return Record{}, fmt.Errorf("parse record conversion fee: %w", err) } - stampDutyTax, err := parseOptinalDecimal(raw[14]) + stampDutyTax, err := parseOptionalDecimal(raw[14]) if err != nil { return Record{}, fmt.Errorf("parse record stamp duty tax: %w", err) } - frenchTxTax, err := parseOptinalDecimal(raw[18]) + frenchTxTax, err := parseOptionalDecimal(raw[18]) if err != nil { return Record{}, fmt.Errorf("parse record french transaction tax: %w", err) } @@ -170,15 +170,15 @@ func figiNatureGetter(ctx context.Context, of *internal.OpenFIGI, isin string) f } // parseFloat attempts to parse a string using a standard precision and rounding mode. -// Using this function helps avoid issues around converting values due to sligh parameter changes. +// Using this function helps avoid issues around converting values due to minor parameter changes. func parseDecimal(s string) (decimal.Decimal, error) { return decimal.NewFromString(s) } -// parseOptinalDecimal behaves the same as parseDecimal but returns 0 when len(s) is 0 instead of +// parseOptionalDecimal behaves the same as parseDecimal but returns 0 when len(s) is 0 instead of // error. -// Using this function helps avoid issues around converting values due to sligh parameter changes. -func parseOptinalDecimal(s string) (decimal.Decimal, error) { +// Using this function helps avoid issues around converting values due to minor parameter changes. +func parseOptionalDecimal(s string) (decimal.Decimal, error) { if len(s) == 0 { return decimal.Decimal{}, nil }