cache calls to SecurityTypeByISIN
All checks were successful
Generate check / check-changes (push) Successful in 4s
Generate check / check-generate (push) Has been skipped
Generate check / check-changes (pull_request) Successful in 3s
Quality / check-changes (pull_request) Successful in 3s
Generate check / check-generate (pull_request) Has been skipped
Quality / tests (pull_request) Successful in 14s
All checks were successful
Generate check / check-changes (push) Successful in 4s
Generate check / check-generate (push) Has been skipped
Generate check / check-changes (pull_request) Successful in 3s
Quality / check-changes (pull_request) Successful in 3s
Generate check / check-generate (pull_request) Has been skipped
Quality / tests (pull_request) Successful in 14s
This avoids unecessary repeated calls to OpenFIGI api
This commit is contained in:
@@ -118,6 +118,42 @@ func TestOpenFIGI_SecurityTypeByISIN(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
func TestOpenFIGI_SecurityTypeByISIN_Cache(t *testing.T) {
|
||||
var alreadyCalled bool
|
||||
c := NewTestClient(t, func(req *http.Request) (*http.Response, error) {
|
||||
if alreadyCalled {
|
||||
t.Fatalf("want requests to be cached")
|
||||
}
|
||||
|
||||
alreadyCalled = true
|
||||
return &http.Response{
|
||||
Status: http.StatusText(http.StatusOK),
|
||||
StatusCode: http.StatusOK,
|
||||
Body: io.NopCloser(bytes.NewBufferString(`[{"data":[{"securityType":"Common Stock"}]}]`)),
|
||||
}, nil
|
||||
})
|
||||
|
||||
of := internal.NewOpenFIGI(c)
|
||||
|
||||
got, gotErr := of.SecurityTypeByISIN(t.Context(), "NL0000235190")
|
||||
if gotErr != nil {
|
||||
t.Fatalf("want 1st success call but got error: %v", gotErr)
|
||||
}
|
||||
|
||||
if got != "Common Stock" {
|
||||
t.Fatalf("want 1st securityType to be %q but got %q", "Common Stock", got)
|
||||
}
|
||||
|
||||
got, gotErr = of.SecurityTypeByISIN(t.Context(), "NL0000235190")
|
||||
if gotErr != nil {
|
||||
t.Fatalf("want 2nd success call but got error: %v", gotErr)
|
||||
}
|
||||
|
||||
if got != "Common Stock" {
|
||||
t.Fatalf("want 2nd securityType to be %q but got %q", "Common Stock", got)
|
||||
}
|
||||
}
|
||||
|
||||
type RoundTripFunc func(req *http.Request) (*http.Response, error)
|
||||
|
||||
func (f RoundTripFunc) RoundTrip(req *http.Request) (*http.Response, error) {
|
||||
|
||||
Reference in New Issue
Block a user